馃挴 #8
Merged
馃挴 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@digitalBush When I |
calvinb
reviewed
Nov 10, 2017
spec/behavior/fileLoader.spec.js
Outdated
| readFile: sinon.stub() | ||
| }; | ||
| fs.readFile.onCall( 0 ).callsArgWith( 2, null, expected ); | ||
| fs.readFile.onCall( 1 ).throws( new Error( "you failed" ) ); |
There was a problem hiding this comment.
Rather than setting different behaviors for different calls, would it be simpler just to assert that fs.readFile is called only once?
calvinb
reviewed
Nov 10, 2017
src/fileLoader.js
Outdated
| @@ -17,7 +17,7 @@ module.exports = function( relativeFile ) { | |||
|
|
|||
| let result = cache[ fileName ]; | |||
| if ( !result ) { | |||
| result = cache[ fileName ] = readFileAsync( fileName, "utf8" ); | |||
| result = cache[ fileName ] = await readFileAsync( fileName, "utf8" ); | |||
There was a problem hiding this comment.
I know this is not part of this PR, but this cache looks like a great place for a Map.
digitalBush
force-pushed
the
feature-fully-covered
branch
from
df3f3e9
to
8a33f57
Compare
|
@calvinb Made the changes you suggested. npm install was fine for me though. Are you running the latest version of node? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings coverage to 100%
