Skip to content

Commit

Permalink
#2 - All TODO items were fulfilled, the last commit was 7cb7e3f. Remo…
Browse files Browse the repository at this point in the history
…ving the TODO list.
  • Loading branch information
IvanJijon committed Mar 29, 2022
1 parent 7cb7e3f commit 2935436
Showing 1 changed file with 0 additions and 22 deletions.
22 changes: 0 additions & 22 deletions ssh/key_reader.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,25 +42,3 @@ func isRSAPrivateKey(pk string) bool {
}
return priv.isRSA()
}

// TODO
// - with a list of file names ✓
// - determine which are RSA public keys ✓
// - determine if a string has the format of an RSA public key ✓
// - try to parse string into SSH public key representation ✓
// - check if the type identifier is ssh-rsa ✓
// - read string from a file, and check if that string is RSA ✓
// - determine which are RSA private keys ✓
// - determine if a string has the format of an RSA private key ✓
// - find or create a basic PEM reader that returns two things for a file - the "tag" for example OPENSSH PRIVATE KEY or RSA PRIVATE KEY, and the main content
// either in base64 or in binary, where the base64 has been unpacked. PEM supports headers, and if the library supports that, fine, but it is not necessary now ✓
// - decode enough of the binary to find ONLY the place that shows that this binary is an SSH private key, and that the type of the key corresponds to RSA ✓
// - binary has to begin with openssh-key-v1 0x00 ✓
// - we dont care at this point if its encrypted or not. we need to read length and jump past 4 fields. ✓
// - we need to read the length for the public key and jump past it. More or less we need to get to the 7th field, which contain the private key keytype ✓
// - read string from a file, and check if that string is RSA private key ✓
// - pair public and private keys to each other based on file name ✓
// - turn each entry into its internal representation ✓
// - go through all files in .ssh, detect if they are public or private keys, and
// create a list for that. then, create a new list with unified content ✓
// - create an internal representation for public, private and key pairs (waiting for GUI needs) ✓

0 comments on commit 2935436

Please sign in to comment.