Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bedrock app key. #2

Merged
merged 5 commits into from
Sep 3, 2021
Merged

Use bedrock app key. #2

merged 5 commits into from
Sep 3, 2021

Conversation

gannan08
Copy link
Contributor

@gannan08 gannan08 commented Sep 2, 2021

No description provided.

dlongley
dlongley approved these changes Sep 2, 2021
View reviewed changes
Copy link
Member

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach is fine -- I commented on a small detail where we might want to change up how bedrock-app-key works so every other module doesn't have to add special exceptions for app.

lib/meters.js Outdated Show resolved Hide resolved
lib/meters.js Outdated Show resolved Hide resolved
gannan08 and others added 2 commits September 2, 2021 15:07
@gannan08
Update br-app-key API usage.
68380f8
@gannan08 @dlongley
Update lib/meters.js.
229bb3f 
Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>
@gannan08 gannan08 marked this pull request as ready for review September 2, 2021 19:11
@gannan08 gannan08 merged commit 7c81357 into main Sep 3, 2021
@gannan08 gannan08 deleted the use-app-key branch September 3, 2021 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlongley dlongley dlongley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gannan08 @dlongley