Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use did io did method web #44

Merged
merged 17 commits into from
Apr 15, 2024
Merged

Use did io did method web #44

merged 17 commits into from
Apr 15, 2024

Conversation

aljones15
Copy link
Contributor

@aljones15 aljones15 commented Dec 21, 2022 •
edited by dlongley
Loading

  • Adds support for did-method-web to verifier
  • Adds tests for did:web
  • Adds a dir for serving did:web during tests
  • Serves a static dir for tests
  • Await this PR: Convert key to web did-method-web#1
  • replace branch of @digitalbazaar/did-method-web with release
  • Add minor release changelog as this only adds new functionality and should be backwards compatible.

@aljones15 aljones15 self-assigned this Dec 21, 2022
@aljones15 aljones15 marked this pull request as ready for review December 21, 2022 21:45
aljones15
aljones15 commented Dec 22, 2022
View reviewed changes
test/test.config.js Outdated Show resolved Hide resolved
aljones15
aljones15 commented Dec 22, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
aljones15
aljones15 commented Dec 22, 2022
View reviewed changes
lib/config.js Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2022 •
edited
Loading

Codecov Report

Merging #44 (5ab2b94) into update-vc-2.0 (98cd5aa) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@              Coverage Diff               @@
##           update-vc-2.0      #44   +/-   ##
==============================================
  Coverage          92.66%   92.66%           
==============================================
  Files                  8        8           
  Lines                981      981           
==============================================
  Hits                 909      909           
  Misses                72       72

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98cd5aa...5ab2b94. Read the comment docs.

dlongley
dlongley requested changes Dec 22, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@dlongley dlongley removed the request for review from JSAssassin April 14, 2024 22:55
@dlongley dlongley changed the base branch from main to update-vc-2.0 April 14, 2024 23:31
@dlongley dlongley merged commit b9f5257 into update-vc-2.0 Apr 15, 2024
4 checks passed
@dlongley dlongley deleted the use-did-io-did-method-web branch April 15, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlongley dlongley dlongley approved these changes

Assignees

@aljones15 aljones15

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aljones15 @codecov-commenter @dlongley