Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add turnstile. #30

Merged
merged 6 commits into from
Oct 17, 2023
Merged

Add turnstile. #30

merged 6 commits into from
Oct 17, 2023

Conversation

mandyvenables
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2023

Codecov Report

Merging #30 (2da539e) into main (d1c7dd6) will decrease coverage by 0.53%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
- Coverage   19.44%   18.91%   -0.53%     
==========================================
  Files           2        2              
  Lines          36       37       +1     
==========================================
  Hits            7        7              
- Misses         29       30       +1     
Files Coverage Δ
lib/AccountService.js 41.17% <100.00%> (ø)
lib/RegisterController.js 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1c7dd6...2da539e. Read the comment docs.

Copy link

@BigBlueHat BigBlueHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great start! Just some general comments while this is in draft mode--nothing to block on necessarily.

lib/RegisterController.js Outdated Show resolved Hide resolved
lib/RegisterController.js Outdated Show resolved Hide resolved
lib/RegisterController.js Outdated Show resolved Hide resolved
lib/RegisterController.js Outdated Show resolved Hide resolved
lib/RegisterController.js Outdated Show resolved Hide resolved
@mandyvenables mandyvenables marked this pull request as ready for review October 12, 2023 21:37
lib/RegisterController.js Outdated Show resolved Hide resolved
Copy link
Member

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor adjustment now to the changelog entry. Thanks!

CHANGELOG.md Outdated
## 5.1.0 - 2023-09-xx

### Added
- Add optional captcha property `authorization` to `AccountService`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Add optional captcha property `authorization` to `AccountService`.
- Add optional account registration authz parameter `authorization` to
`AccountService.create()`.

CHANGELOG.md Outdated
@@ -1,5 +1,10 @@
# bedrock-web-account ChangeLog

## 5.1.0 - 2023-09-xx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## 5.1.0 - 2023-09-xx
## 5.1.0 - 2023-10-xx

@mandyvenables mandyvenables merged commit bc3e012 into main Oct 17, 2023
3 checks passed
@mandyvenables mandyvenables deleted the add-turnstile branch October 17, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants