Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature to throw error when unmapped elements are dropped during processing #199

Open
dlongley opened this issue Sep 12, 2017 · 5 comments
Open

Add feature to throw error when unmapped elements are dropped during processing #199

dlongley opened this issue Sep 12, 2017 · 5 comments
Assignees
@msporny @davidlehn @dlongley @mattcollier

Comments

@dlongley
Copy link
Member

When certain elements in a document cannot be mapped to absolute URLs (via @context or a base URL), then are silently dropped during expansion per the spec. There should be a feature in this processor that, instead, causes an error to be raised. This is particularly important when this library is used in conjunction with digital signing libraries.

Related to #178.
@dlongley dlongley mentioned this issue Sep 12, 2017
Closed
@dlongley
Copy link
Member Author

Partially supported with expansionMap and compactionMap here: bcae961

Still need something for toRDF.

@kimdhamilton kimdhamilton mentioned this issue Oct 8, 2017
Closed
@dlongley
Copy link
Member Author

Specifically, when converting to RDF, relative URIs are dropped and this should be handled by another map or similar mechanism.

@dlongley dlongley mentioned this issue Apr 9, 2020
Closed
sudeshrshetty added a commit to sudeshrshetty/aries-framework-go that referenced this issue Apr 10, 2020
@sudeshrshetty
feat: Handling invalid RDF in canonized JSON LD
4b6e484 
Previously: we weren't dropping undefined terms from RDFs.

Fix: changed normalization aproach through json-gold library so that it
returns parsing error whenever invalid data found in dataset.

Added error handling logic for invalid RDF data errors where aries json
ld processor is going to remove the invalid data from dataset and try
again recursively. (Following
digitalbazaar/jsonld.js#199)

closes hyperledger-archives#1592

Signed-off-by: sudesh.shetty <sudesh.shetty@securekey.com>
sudeshrshetty added a commit to sudeshrshetty/aries-framework-go that referenced this issue Apr 10, 2020
@sudeshrshetty
feat: Handling invalid RDF in canonized JSON LD
1ed4441 
Previously: we weren't dropping undefined terms from RDFs.

Fix: changed normalization aproach through json-gold library so that it
returns parsing error whenever invalid data found in dataset.

Added error handling logic for invalid RDF data errors where aries json
ld processor is going to remove the invalid data from dataset and try
again recursively. (Following
digitalbazaar/jsonld.js#199)

closes hyperledger-archives#1592

Signed-off-by: sudesh.shetty <sudesh.shetty@securekey.com>
@sudeshrshetty sudeshrshetty mentioned this issue Apr 10, 2020
Merged
sudeshrshetty added a commit to sudeshrshetty/aries-framework-go that referenced this issue Apr 10, 2020
@sudeshrshetty
feat: Handling invalid RDF in canonized JSON LD
4ace988 
Previously: we weren't dropping undefined terms from RDFs.

Fix: changed normalization aproach through json-gold library so that it
returns parsing error whenever invalid data found in dataset.

Added error handling logic for invalid RDF data errors where aries json
ld processor is going to remove the invalid data from dataset and try
again recursively. (Following
digitalbazaar/jsonld.js#199)

closes hyperledger-archives#1592

Signed-off-by: sudesh.shetty <sudesh.shetty@securekey.com>
sudeshrshetty added a commit to sudeshrshetty/aries-framework-go that referenced this issue Apr 10, 2020
@sudeshrshetty
feat: Handling invalid RDF in canonized JSON LD
0c6d1d1 
Previously: we weren't dropping undefined terms from RDFs.

Fix: changed normalization aproach through json-gold library so that it
returns parsing error whenever invalid data found in dataset.

Added error handling logic for invalid RDF data errors where aries json
ld processor is going to remove the invalid data from dataset and try
again recursively. (Following
digitalbazaar/jsonld.js#199)

closes hyperledger-archives#1592

Signed-off-by: sudesh.shetty <sudesh.shetty@securekey.com>
sudeshrshetty added a commit to sudeshrshetty/aries-framework-go that referenced this issue Apr 11, 2020
@sudeshrshetty
feat: Handling invalid RDF in canonized JSON LD
593f030 
Previously: we weren't dropping undefined terms from RDFs.

Fix: changed normalization aproach through json-gold library so that it
returns parsing error whenever invalid data found in dataset.

Added error handling logic for invalid RDF data errors where aries json
ld processor is going to remove the invalid data from dataset and try
again recursively. (Following
digitalbazaar/jsonld.js#199)

closes hyperledger-archives#1592

Signed-off-by: sudesh.shetty <sudesh.shetty@securekey.com>
@dlongley dlongley mentioned this issue May 1, 2020
Closed
This was referenced May 26, 2020
Open
Closed
@dlongley dlongley mentioned this issue Jul 15, 2020
Closed
@dlongley dlongley mentioned this issue Oct 8, 2020
Open
@OR13 OR13 mentioned this issue Nov 9, 2020
Open
@OR13
Copy link

OR13 commented Nov 9, 2020

@dlongley I want to make this explode, whats the easiest way to do that?

I have this PR with a failing test: transmute-industries/vc.js#26

@OR13 OR13 mentioned this issue Nov 16, 2020
Closed
@dlongley dlongley mentioned this issue Dec 9, 2020
Closed
@dlongley
Copy link
Member Author

dlongley commented Dec 9, 2020

@OR13,

I want to make this explode, whats the easiest way to do that?

Sorry, just seeing this now, a month later. Using an undefined type with no base set or -- as it says in the issue I just linked to -- a non-URI for an id will cause silent droppage. Not sure if that's "exploding" though. :)

@OR13
Copy link

OR13 commented Dec 11, 2020

explode means that when someone hands json that has been mutated after being signed, a verifier will throw an error on it, not return "verified".

@tplooker tplooker mentioned this issue May 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msporny msporny

@davidlehn davidlehn

@dlongley dlongley

@mattcollier mattcollier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@msporny @davidlehn @dlongley @mattcollier @OR13