Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to make the package work with latest node/io #112

Closed
wants to merge 1 commit into from

Conversation

yamalight
Copy link

Update of the dependencies to make the package work with latest node/io (v3.x and v4.x).
Will close #110

@dlongley
Copy link
Member

Unfortunately, jsdom 4.0+ doesn't work with node 0.10 or node 0.12. Until we separate the RDFa parser from this package (which we should, see: #98), we can't upgrade jsdom past 3.x.

@yamalight
Copy link
Author

@dlongley why not publish it as next major version and backport fixes (which would be trivial since difference is only in deps versions) when needed to older version? (e.g. 0.3.x for pre 3.0 and 0.4.x for 3.0+)

@dlongley
Copy link
Member

@yamalight, I was holding out hope to cut the RDFa stuff out entirely before jumping to the next version. That way we only have to deal with two versions instead of three ... as we'll have to bump versions again once we move RDFa support to a separate package. We may do that (what you suggest) anyway, because we haven't had time (and there have been no PRs) to split RDFa out of the package in a long while.

@yamalight
Copy link
Author

@dlongley did I get it correctly that the only part that uses RDFa is jsonld.request = require('./request');? If yes, then it should be pretty easy to split that into separate optional module, right? If not, I'll dig in a bit more tomorrow.

If this split will speed up the update to 4.0.0, I'm willing to do this over tomorrow and send a PR, since we're depending on this module too much :)

@dlongley
Copy link
Member

@yamalight, I'm going to cc @davidlehn to provide more details on splitting stuff out. Since he worked on the RDFa integration stuff he'll have a better idea of how easy it should be than me.

@davidlehn
Copy link
Member

I split request extension into https://github.com/digitalbazaar/jsonld-request and cli tool into https://github.com/digitalbazaar/jsonld-cli. If you just need to use core jsonld lib, this may fix dependency issues.

@yamalight
Copy link
Author

@davidlehn yep, works great now, thanks!
I'll close the PR since it's not needed anymore.

@yamalight yamalight closed this Sep 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to install with iojs@3.0.0
3 participants