-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
framing with "@embed": "@link" cannot handle circular references #64
Comments
I doubt this feature has been tested. Sorry about that. The test suites need updates to check these newer features. The code was probably ported from jsonld.js long ago. Might be worth checking if it works in jsonld.js, and if so then compare the code to see what might have changed or not been ported properly. |
An empty dict is not truthy in python, so cannot just check for "if options['link']" Fixes digitalbazaar#64
I'm actually not sure how to write a test for this within the existing testing framework, since the framed result is not representable directly in json (so there is no way to write a |
An empty dict is not truthy in python, so cannot just check for "if options['link']" Fixes digitalbazaar#64
Framing with "@embed": "@link" has been proposed as one way to create an in-memory representation of a graph (as discussed in json-ld/json-ld.org#140 ).
jsonld.js does this in a way that handles circular references, but when I try to use pyld to frame:
with a frame like:
... I get a RuntimeError from exceeding the recursion limit.
I also demonstrate this in a gist
The text was updated successfully, but these errors were encountered: