Optimize IdentifierIssuer existing Map. #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change clones from always-copy to copy-on-write. - Depending on shape of data, this can reduce `Map` copies by ~90%. However, in some data patterns, these will have very few entries, so overall performance may not be noticeably effected.
davidlehn
force-pushed
the
copy-on-write-identifier-map
branch
from
80e1b96
to
3d15697
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #65 +/- ##
==========================================
+ Coverage 88.44% 88.52% +0.07%
==========================================
Files 10 10
Lines 580 584 +4
==========================================
+ Hits 513 517 +4
Misses 67 67
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dlongley
approved these changes
Mar 31, 2023
| this.prefix = prefix; | ||
| this._existing = existing; |
There was a problem hiding this comment.
Let's keep the prefixed _ so only protected / internal usage of this is expected.
There was a problem hiding this comment.
Ok. But it's not consistent. counter is only used internally, but has no leading _.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mapcopies by ~90%. However, in some data patterns, these will have very few entries, so overall performance may not be noticeably effected.This patch may need more work. It doesn't seem to hurt anything. Benchmarking was difficult, and it may even be slightly slower for small tests? Unclear why that would be other than faulty benchmarking.
I had expected this to show up better in benchmarks. But it seems the timing effect may be minimal. Perhaps the memory usage of fewer maps is more measurable, but I'm unsure how best to do so. For example, running the test suite with just the async code, the
clonecalls will do 25602 Map copies. With this patch it will only do 2307 copies.As noted in the code, there is a case of clones being done, but they won't unref the shared map, so another user of that map might copy it needlessly. This is a bit more involved to fix, and it's unclear how often that may happen.