Add signal support, remove legacy code, fix blanknodes. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaking change to remove the deprecated legacy dataset format.
- Async: Add `signal` option for an `AbortSignal`. - Sync: Add `timeout` option for common timeout use case. - Add docs.
- Reordering and renumbering, no functional change.
- Support `rdfc:RDFC10NegativeEvalTest`. - Support `rdfc:RDFC10MapTest`. - Cleanups.
**BREAKING**: Change dataset handling of `BlankNodes` to match the [RDF/JS: Data model specification](https://rdf.js.org/data-model-spec/). The `_:` prefix is no longer used in the `BlankNode` `value` field. This should improve compatibility with other RDF/JS tooling but may cause compatibility issues with existing code. The previous behavior is historical and may predate the RDF/JS spec.
- Add large graph creation utilities. - Add timeout test. - Add maxDeepIteration test. - Add developer playground for large graph tests.
- Add `messageDigestAlgorithm` option to API. - Add support for SHA-256, SHA-384, and SHA-512 name variations to `MessageDigests`. - Updates tests to handle `hashAlgorithm` option if present.
Codecov Report
@@ Coverage Diff @@
## main-with-3.4.0 #77 +/- ##
===================================================
+ Coverage 90.08% 94.97% +4.89%
===================================================
Files 10 10
Lines 625 637 +12
===================================================
+ Hits 563 605 +42
+ Misses 62 32 -30
Continue to review full report in Codecov by Sentry.
|
**BREAKING**: Check output `format` parameter. Must be omitted, falsey, or "application/n-quads".
- Remove advanced "useNative" example. - Add common N-Quads input example.
- Add `maxWorkFactor` to calculate `maxDeepIterations` based on non-unique blank nodes. Default to `1`. - If `maxDeepIterations` is >= 0 then use it explicitly. - Remove default timeout signal. - Add docs. - Add tests. - Update async and sync versions. - Update tests to handle `computationalComplexity` test paramter and map it to `maxWorkFactor` adjustments. - Improve negative test handling.
Add support for generalized RDF `BlankNode` predicate during N-Quads serialization.
Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>
- Fix maxWorkFactor === 0 use case. - Improve error if N-Quads input not a string. - Fix calls without options. - Test error messages to ensure correct errors are thrown. - Remove default options not needed for testing. - Add various tests for complexity controls, edge cases, and coverage. - Add simple duplicate quads test.
- Rename `URDNA2015.js` to `RDFC10.js`. - Rename 'URDNA2015` class to `RDFC10`. - Rename `URDNA2015Sync.js` to `RDFC10Sync.js`. - Rename 'URDNA2015Sync` class to `RDFC10Sync`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbortSignalsignaloption for complexity control via timeouts, manual abort, or other condition.timeoutto private sync version._:prefix inBlankNodesto improve compatibility with RDF/JS tooling. (Need to test what other tooling issues this may cause, for instance in jsonld.js.)A 1000ms default timeout is set here. I'm not sure if that's the best approach or have no abort signal here and let other libraries and apps add a default that fits their use case.