Update complexity controls. #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**BREAKING**: Check output `format` parameter. Must be omitted, falsey, or "application/n-quads".
- Remove advanced "useNative" example. - Add common N-Quads input example.
- Add `maxWorkFactor` to calculate `maxDeepIterations` based on non-unique blank nodes. Default to `1`. - If `maxDeepIterations` is >= 0 then use it explicitly. - Remove default timeout signal. - Add docs. - Add tests. - Update async and sync versions. - Update tests to handle `computationalComplexity` test paramter and map it to `maxWorkFactor` adjustments. - Improve negative test handling.
Codecov Report
@@ Coverage Diff @@
## add-signal-support #79 +/- ##
======================================================
+ Coverage 93.59% 94.97% +1.38%
======================================================
Files 10 10
Lines 609 637 +28
======================================================
+ Hits 570 605 +35
+ Misses 39 32 -7
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Add support for generalized RDF `BlankNode` predicate during N-Quads serialization.
davidlehn
force-pushed
the
refactor-complexity-limit
branch
from
fb7d15c
to
029a88c
Compare
dlongley
approved these changes
Sep 19, 2023
Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>
- Fix maxWorkFactor === 0 use case. - Improve error if N-Quads input not a string. - Fix calls without options. - Test error messages to ensure correct errors are thrown. - Remove default options not needed for testing. - Add various tests for complexity controls, edge cases, and coverage. - Add simple duplicate quads test.
davidlehn
force-pushed
the
refactor-complexity-limit
branch
from
c58827b
to
f3ade06
Compare
- Rename `URDNA2015.js` to `RDFC10.js`. - Rename 'URDNA2015` class to `RDFC10`. - Rename `URDNA2015Sync.js` to `RDFC10Sync.js`. - Rename 'URDNA2015Sync` class to `RDFC10Sync`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maxWorkFactorparameter.