Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example usage script. #162

Draft
wants to merge 107 commits into
base: update-vc-2.0
Choose a base branch
from
Draft

Add example usage script. #162

wants to merge 107 commits into from

Conversation

davidlehn
Copy link
Member

No description provided.

@aljones15 aljones15 force-pushed the vc-2.0-time-props branch 2 times, most recently from f8099c3 to dbaf8c8 Compare December 8, 2023 17:53
@aljones15
Add credentials v2 context to deps.
006f5b8
@aljones15
Add credentials v2 context to doc loader and check for it.
7994dc9
@aljones15
Add credentials context V2 to test contexts.
a999eda
@aljones15
Add invalid and valid contexts to test suite & add ed25519 context to…
751442b 
… test contexts.
@aljones15
Make VC v2 context default.
72278eb
@aljones15
Add issuanceDate to v1 VCs, validate issuanceDate v1, remove issuance…
349ff94 
…Date test data.
@aljones15
Add contexts, testLoader, & documentLoader to separate files.
42bd9a1
@aljones15
Add v1 and v2 mock credential.
9c2e7f6
@aljones15
Start moving test data to use both v1 and v2 credentials.
709705d
@aljones15
Use v1 context for now > issuanceDate test.
ad0f279
@aljones15
Use private variable to avoid confusion with exported contexts.
28b3515
@aljones15
Reject is credentialSubject is empty.
a0c0315
@aljones15
Add guards against non-object and null.
b932b78
@aljones15
Add multiple credentialSubject tests.
eaeba17
@aljones15
Clarify logic around isObject & throw if subject not object.
288b26d
@aljones15
Add check for objects that must have a type.
86f1982
@aljones15
Use double-quotes for properties in error messages.
d252cea
@aljones15
Add @Private to private methods.
b8b1598
@aljones15
Add MAJOR CHANGELOG entry for vc 2.0 upgrade.
0affec2
@aljones15
Clean up: move Data Integrity & Multikey contexts to loader helper file.
3a206b1
@aljones15
Tests run on both v1 and v2 VCs.
dbd1b6e
@aljones15
Run all tests not just one failing one.
4eb291a
@aljones15
Adjust mandatoryPointers for v1 and v2 VCs.
aa94e39
@aljones15
Correct typo in main test title.
5ee2823
@aljones15
Use jsonld.clone for consistency and to prevent test data mutation.
efa0ad9
@aljones15
Set presentation context to v1 if vcs contains a v1 context.
742b0cb
@aljones15
Pluralize VCs in test title to match spec.
c09f3b8
aljones15 and others added 26 commits April 29, 2024 12:12
@aljones15 @JSAssassin @dlongley
Update test/10-verify.spec.js add is to test title.
0e95409 
Co-authored-by: Tashi D. Gyeltshen <38434620+JSAssassin@users.noreply.github.com>
@aljones15 @JSAssassin @dlongley
Update lib/helpers.js correct grammar in test title.
53a6a54 
Co-authored-by: Tashi D. Gyeltshen <38434620+JSAssassin@users.noreply.github.com>
@aljones15 @dlongley
Make test fail description for validFrom consistent with others.
54e38d3
@aljones15 @dlongley
Use dynamic dates for issue tests.
05d5bac
@aljones15 @dlongley
Use live dates to better integration test expiration logic.
13662e0
@aljones15 @dlongley
Use full ISOString for dynamic dates.
a128e0e
@aljones15 @dlongley
Drop the from validBefore and validAfter error messages.
8cac066
@aljones15 @dlongley
Assert on error messages for validUntil and validBefore.
6c49c09
@aljones15 @dlongley
Date checks return datetime verbatim & use seconds in test data.
da560fe
@aljones15 @dlongley
Use mockCredential() in validFrom & validUntil same time test.
fd768e6
@aljones15 @dlongley
Move expirationDate test to v1 tests & use mockCredential in all tests.
b3da66d
@aljones15 @dlongley
Add issuanceDate format check under issuanceDate existence check in V…
b483751 
…C 1.0 checks.
@aljones15 @dlongley
Check validUntil & validFrom format on issue.
a354ee5
@aljones15 @JSAssassin @dlongley
Update lib/index.js clarify jsdoc comments about issuanceDate.
bdaa193 
Co-authored-by: Tashi D. Gyeltshen <38434620+JSAssassin@users.noreply.github.com>
@aljones15 @JSAssassin @dlongley
Update test/10-verify.spec.js remove extra blank line.
a8b032d 
Co-authored-by: Tashi D. Gyeltshen <38434620+JSAssassin@users.noreply.github.com>
@aljones15 @JSAssassin @dlongley
Update test/helpers.js use substring & template string for date time …
0310d43 
…stamp.

Co-authored-by: Tashi D. Gyeltshen <38434620+JSAssassin@users.noreply.github.com>
@aljones15 @dlongley
Remove extra semicolon from inline github code edit.
b686adf
@davidlehn @dlongley
Update credentialStatus checks.
e26bb5b 
- Make "id" optional.
- If "id" present, check it's a URL.
- Add tests.
@davidlehn @dlongley
Fix credentialStatus id test typos.
49c2c0b
@aljones15 @BigBlueHat @dlongley
Update test/10-verify.spec.js remove ref to validAfter in jsdoc comment.
8fe9df0 
Co-authored-by: BigBlueHat <byoung@bigbluehat.com>
@aljones15 @BigBlueHat @dlongley
Update CHANGELOG.md remove validAfter from CHANGELOG.
eff366c 
Co-authored-by: BigBlueHat <byoung@bigbluehat.com>
@aljones15 @dlongley
Import mock.data in verify & export credentials from mock.data.
dfb9f47
@dlongley
Attempt to fix codecov upload.
d3abfab
@davidlehn
Add roundtrip example.
dfc7284
@davidlehn
Example updates.
7559543 
- Use verify suite.
- Add multikey resolver.
@dlongley @davidlehn
Ensure VC issuer matches key controller.
67e109e
@davidlehn davidlehn changed the base branch from vc-2.0-time-props to update-vc-2.0 May 17, 2024 20:39
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.54%. Comparing base (d3abfab) to head (67e109e).

Additional details and impacted files 
@@              Coverage Diff               @@
##           update-vc-2.0     #162   +/-   ##
==============================================
  Coverage          90.54%   90.54%           
==============================================
  Files                  5        5           
  Lines               1058     1058           
==============================================
  Hits                 958      958           
  Misses               100      100

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3abfab...67e109e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@davidlehn @codecov-commenter @aljones15 @dlongley