Skip to content

Commit

Permalink
Merge pull request openhab#67 from digitaldan/omni-remove-console-dis…
Browse files Browse the repository at this point in the history
…covery

removes console discovery, fixes openhab#62
  • Loading branch information
craigham committed Jul 7, 2017
2 parents a0dfd42 + baaa825 commit 0d7474a
Showing 1 changed file with 0 additions and 29 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
import com.digitaldan.jomnilinkII.MessageTypes.properties.AreaProperties;
import com.digitaldan.jomnilinkII.MessageTypes.properties.AudioZoneProperties;
import com.digitaldan.jomnilinkII.MessageTypes.properties.ButtonProperties;
import com.digitaldan.jomnilinkII.MessageTypes.properties.ConsoleProperties;
import com.digitaldan.jomnilinkII.MessageTypes.properties.ThermostatProperties;
import com.digitaldan.jomnilinkII.MessageTypes.properties.UnitProperties;
import com.digitaldan.jomnilinkII.MessageTypes.properties.ZoneProperties;
Expand Down Expand Up @@ -72,8 +71,6 @@ protected void startScan() {
discoverButtons();
discoverThermostats();
discoverAudioZones();
// generate consoles is throwing and error
// generateConsoles();
} catch (OmniInvalidResponseException | OmniUnknownMessageTypeException | BridgeOfflineException e) {
logger.debug("Received error during discovery", e);
}
Expand Down Expand Up @@ -118,32 +115,6 @@ private void discoverButtons()
}
}

private void generateConsoles()
throws OmniInvalidResponseException, OmniUnknownMessageTypeException, BridgeOfflineException {

for (AreaProperties areaProperties : areas) {
int areaFilter = bitFilterForArea(areaProperties);

ObjectPropertyRequest<ConsoleProperties> objectPropertyRequest = ObjectPropertyRequest
.builder(bridgeHandler, ObjectPropertyRequests.CONSOLE).areaFilter(areaFilter).build();

for (ConsoleProperties consoleProperties : objectPropertyRequest) {

int objnum = consoleProperties.getNumber();
Map<String, Object> properties = new HashMap<>();
ThingUID thingUID = new ThingUID(OmnilinkBindingConstants.THING_TYPE_CONSOLE,
bridgeHandler.getThing().getUID(), Integer.toString(objnum));
properties.put(OmnilinkBindingConstants.THING_PROPERTIES_NUMBER, objnum);
properties.put(OmnilinkBindingConstants.THING_PROPERTIES_AREA, areaProperties.getNumber());

DiscoveryResult discoveryResult = DiscoveryResultBuilder.create(thingUID).withProperties(properties)
.withBridge(this.bridgeHandler.getThing().getUID()).withLabel(consoleProperties.getName())
.build();
thingDiscovered(discoveryResult);
}
}
}

private void discoverAudioZones()
throws OmniInvalidResponseException, OmniUnknownMessageTypeException, BridgeOfflineException {

Expand Down

0 comments on commit 0d7474a

Please sign in to comment.