Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helper): Fix workaround include #14

Merged
merged 1 commit into from
Feb 19, 2018
Merged

Conversation

Cryt1c
Copy link
Contributor

@Cryt1c Cryt1c commented Feb 11, 2018

With this PR the workaround functions are working again.

@digitaldonkey
Copy link
Owner

As far as I understand PSR-4 recommendations the helpers should be loaded like

"files": [
"src/helpers/ethereum-client-workaround-helpers.php"
]

See also: https://stackoverflow.com/a/28290359/308533

But as you found out that doesn't work.
Maybe the path should not have src?

@digitaldonkey digitaldonkey merged commit e116ee3 into digitaldonkey:dev Feb 19, 2018
@digitaldonkey
Copy link
Owner

See also 20d781e

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants