Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically validate location data of POI model #1000

Open
4 of 6 tasks
Tracked by #1039
timobrembeck opened this issue Oct 30, 2021 · 7 comments
Open
4 of 6 tasks
Tracked by #1039

Automatically validate location data of POI model #1000

timobrembeck opened this issue Oct 30, 2021 · 7 comments
Labels
💡 feature New feature or request ⁉️ prio: low Not urgent, can be resolved in the distant future. 😱 effort: high Big change, which requires >12h
Milestone

Comments

@timobrembeck
Copy link
Member

timobrembeck commented Oct 30, 2021

Motivation

At the moment, it is possible to insert incorrect data for the exact position of POIs. Since there are many possible pitfalls when creating POIs, we should validate the input and auto-fill as much as possible.

Proposed Solution

Possible ideas (check effort vs. usability on each step):

  • Validate whether an address format is correct
  • Validate whether a street exists in the given city
  • Suggest available streets on the selected city
  • Auto-fill city after zip code has been inserted
  • Auto-fill coordinates after address is complete
  • If coordinates are manually changed after auto-fill, check for consistency with the address data and raise a warning if the positions are completely off

Alternatives

Additional Context

@timobrembeck timobrembeck added the 💡 feature New feature or request label Oct 30, 2021
@timobrembeck timobrembeck added this to the Version 1.0 milestone Oct 30, 2021
@svenseeberg
Copy link
Member

svenseeberg commented Oct 30, 2021

Honestly, I do not think that this is that important. As with all content that is created in the app, the content creators need to take care that everything is "correct". I think it would be most important to show a preview of the location on a small embedded map to simply show where the location actually is on a map. I would also argue that this is not necessary for a release, only nice to have.

@ulliholtgrave
Copy link
Member

I agree with Sven, a validation is surely a nice thing to have, but the wordpress doesn't have it. Therefore I suggest to postpone it to Version 2.0 and add the prio:high label.

@timobrembeck
Copy link
Member Author

Alright, seems reasonable! 👍

@timobrembeck
Copy link
Member Author

We could use our geocoding service for this:
http://nominatim.maps.tuerantuer.org/nominatim/search.php?street=Am%20B%C3%BChl&postalcode=86199

API documentation: https://nominatim.org/release-docs/develop/api/Overview/

@dkehne
Copy link

dkehne commented Jul 20, 2022

Isn't that also related to #1035 ?

@timobrembeck
Copy link
Member Author

Isn't that also related to #1035 ?

Yes, it's related, but can be implemented independently of each other.

@MizukiTemma MizukiTemma self-assigned this Oct 9, 2022
@timobrembeck timobrembeck added ⁉️ prio: low Not urgent, can be resolved in the distant future. and removed ‼️ prio: high Needs to be resolved ASAP. labels Oct 18, 2022
@timobrembeck timobrembeck modified the milestones: 22Q4, Backlog Oct 18, 2022
@timobrembeck
Copy link
Member Author

Since this is now mostly done, I decreased the prio of the remaining tasks and moved it back into the backlog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 feature New feature or request ⁉️ prio: low Not urgent, can be resolved in the distant future. 😱 effort: high Big change, which requires >12h
Projects
None yet
Development

No branches or pull requests

5 participants