Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically derive location coordinates from address #1377

Merged
merged 3 commits into from
May 2, 2022

Conversation

timobrembeck
Copy link
Member

Short description

Automatically derive location coordinates from address

Proposed changes

  • Add geopy for Nominatim API client
  • Automatically derive location coordinates from address
  • Show warning when manual coordinates are too far away from Nominatim API result
  • Make coordinates optional for locations not on map

Resolved issues

Fixes (partially): #1000
Fixes: #1180

@timobrembeck timobrembeck requested a review from a team as a code owner April 30, 2022 17:36
@codeclimate
Copy link

codeclimate bot commented Apr 30, 2022

Code Climate has analyzed commit 61ccfe1 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 3

The test coverage on the diff in this pull request is 51.9% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.9% (0.0% change).

View more on Code Climate.

Copy link
Member

@ulliholtgrave ulliholtgrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. I tried it and everything seems to work just as expected 👍
Just one small issue: Could you add some initial debug message that the Normatim API is available/used? So something similar like the GVZ and DeepL API?

@ulliholtgrave
Copy link
Member

Thanks for adding this API check 👍 I guess this is good to go, if the pylint issues are adressed 🎉

@timobrembeck timobrembeck merged commit a7f2239 into develop May 2, 2022
@timobrembeck timobrembeck deleted the feature/poi-coordinates branch May 2, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save location on map without coordinates
2 participants