Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to deliver fallback for missing translations for Events and POIs #1001

Closed
timobrembeck opened this issue Oct 30, 2021 · 4 comments · Fixed by #1339
Closed

Add option to deliver fallback for missing translations for Events and POIs #1001

timobrembeck opened this issue Oct 30, 2021 · 4 comments · Fixed by #1339
Assignees
Labels
💡 feature New feature or request ❗ prio: medium Should be scheduled in the forseeable future.
Milestone

Comments

@timobrembeck
Copy link
Member

timobrembeck commented Oct 30, 2021

Motivation

Parts of the content are less language-dependent than others (e.g. lists of contact-addresses) or change so frequently that they are not translated via the normal workflow. Instead, some regions want to show the translation in the region's default language per default for translations that are missing.

Proposed Solution

  • For the content types Event and POI, add a new option to the region model to determine whether missing translations should be delivered in the region's default language.
  • In the API, deliver the fallback translation for each missing translation if this option is enabled
  • Adapt the translation report and icons in the page list to make it more obvious that the translations are in fact missing, but the fallback translations are shown in the apps instead.

Alternatives

Additional Context

@timobrembeck timobrembeck added the 💡 feature New feature or request label Oct 30, 2021
@timobrembeck timobrembeck added this to the Version 1.0 milestone Oct 30, 2021
@svenseeberg svenseeberg added the ❗ prio: medium Should be scheduled in the forseeable future. label Oct 30, 2021
@ulliholtgrave
Copy link
Member

Is this the same behavior as in the Wordpress system? As you can see in the screenshots, we have pages that are available in different languages (see the extra language for the corona information).
grafik

grafik

@melegiul melegiul self-assigned this Nov 9, 2021
@svenseeberg svenseeberg added the ❓ question Further information is requested label Nov 10, 2021
@svenseeberg
Copy link
Member

As the app uses slugs for identifying objects (pages, news, etc) we need to ask the app team what happens if the same slug is used for another language.

@timobrembeck
Copy link
Member Author

As the app uses slugs for identifying objects (pages, news, etc) we need to ask the app team what happens if the same slug is used for another language.

I don't think this has anything to do with this issue. We already allow the same slug for different languages, even for manually created translations, so if this is a problem, it's one independently from this issue.

But this doesn't seem to be an issue, e.g.

work just fine. Probably the app uses the whole path augsburg/de/corona-virus and augsburg/en/corona-virus as identifier for a translation.

@timobrembeck
Copy link
Member Author

timobrembeck commented Dec 7, 2021

This issue is no longer as relevant, because we need duplicates for individual pages anyway (see issue #1053).
So we should keep this idea in our minds, but let's move that to the backlog and think about it another time.

@timobrembeck timobrembeck added ⁉️ prio: low Not urgent, can be resolved in the distant future. and removed ❓ question Further information is requested ❗ prio: medium Should be scheduled in the forseeable future. labels Dec 7, 2021
@timobrembeck timobrembeck modified the milestones: Version 1.2, Backlog Dec 7, 2021
@timobrembeck timobrembeck added the 🚫 wontfix This will not be worked on label Dec 7, 2021
@timobrembeck timobrembeck removed this from the Backlog milestone Feb 11, 2022
@timobrembeck timobrembeck removed 💡 feature New feature or request ⁉️ prio: low Not urgent, can be resolved in the distant future. labels Feb 11, 2022
@timobrembeck timobrembeck added this to the Backlog milestone Feb 11, 2022
@timobrembeck timobrembeck removed this from the Backlog milestone Mar 2, 2022
@timobrembeck timobrembeck changed the title Add option to deliver fallback for missing translations Add option to deliver fallback for missing translations for Events and POIs Mar 2, 2022
@timobrembeck timobrembeck added 💡 feature New feature or request ⁉️ prio: low Not urgent, can be resolved in the distant future. and removed 🚫 wontfix This will not be worked on labels Mar 2, 2022
@timobrembeck timobrembeck added this to the Version 1.1 milestone Mar 2, 2022
@timobrembeck timobrembeck added ❗ prio: medium Should be scheduled in the forseeable future. and removed ⁉️ prio: low Not urgent, can be resolved in the distant future. labels Mar 2, 2022
@JoeyStk JoeyStk self-assigned this Mar 7, 2022
@JoeyStk JoeyStk added 👼 help wanted Extra attention is needed and removed 👼 help wanted Extra attention is needed labels Mar 29, 2022
@JoeyStk JoeyStk removed their assignment Apr 21, 2022
@timobrembeck timobrembeck self-assigned this Apr 22, 2022
@timobrembeck timobrembeck modified the milestones: Version 1.1, Version 1.2 May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 feature New feature or request ❗ prio: medium Should be scheduled in the forseeable future.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants