Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XLIFF files imported as draft translations #1284

Closed
svenseeberg opened this issue Mar 9, 2022 · 5 comments · Fixed by #1288
Closed

XLIFF files imported as draft translations #1284

svenseeberg opened this issue Mar 9, 2022 · 5 comments · Fixed by #1288
Assignees
Labels
‼️ prio: high Needs to be resolved ASAP. 🐛 bug Something isn't working
Milestone

Comments

@svenseeberg
Copy link
Member

Describe the Bug

After importing translations from XLIFF files the status of the translation is set to draft.

Steps to Reproduce

  1. Open https://malte-test.tuerantuer.org/gumv/pages/de/
  2. Select the Ukraine zip file and import
  3. Translations are imported, but status is set to draft.

Expected Behavior

Pages should be visible.

Additional Information

The issue description is probably incomplete.

@svenseeberg svenseeberg added the 🐛 bug Something isn't working label Mar 9, 2022
@svenseeberg svenseeberg added this to the Version 1.1 milestone Mar 9, 2022
@svenseeberg svenseeberg added the ‼️ prio: high Needs to be resolved ASAP. label Mar 9, 2022
@timobrembeck
Copy link
Member

This happens when no translation exists for the imported language or the latest translation is a draft.

@timobrembeck
Copy link
Member

Should probably be implemented together with #1047

@svenseeberg
Copy link
Member Author

That means the translation should inherit the status of the source at the time of export? 🤔 And we make it 2 bulk actions "Export published versions as XLIFF" vs "Export most current versions as XLIFF"?

@timobrembeck
Copy link
Member

I'm not sure, I would prefer the solution to just export public versions and set the status to public for all imported versions again. For edge cases where drafts should be exported, we could suggest the workaround to publish them temporarily, export them as XLIFF and hide them again? But this is no real use case I think, since in most cases the translation should only happen when the content is finished and not a draft anymore.

@timobrembeck timobrembeck self-assigned this Mar 10, 2022
@timobrembeck
Copy link
Member

After clarification with the municipality team, the workflow should be exactly as it is at the moment, with the exception that the status should be inherited from the source language when no translation exists (in contrast to the fallback to DRAFT like it is at the moment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
‼️ prio: high Needs to be resolved ASAP. 🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants