Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark external links, phone numbers, etc. #1333

Closed
Tracked by #1428
svenseeberg opened this issue Apr 1, 2022 · 0 comments · Fixed by #1796
Closed
Tracked by #1428

Mark external links, phone numbers, etc. #1333

svenseeberg opened this issue Apr 1, 2022 · 0 comments · Fixed by #1796
Assignees
@charludo
Labels
‼️ prio: high Needs to be resolved ASAP. 💡 feature New feature or request 😱 effort: high Big change, which requires >12h
Milestone
22Q4

Comments

@svenseeberg
Copy link
Member

svenseeberg commented Apr 1, 2022 •
edited

Motivation

We want to mark external links, phone numbers, etc with decicated icons to make it easier for users to understand what clicking on them will do:

  • Will it open an external / third party website or the phone app
  • Users should know if a resource is available offline in the app
  • Increased trust

Proposed Solution

When inserting a link with TinyMCE, external, phone or e-mail links (not pointing to the CMS domain) should get an additional CSS class. This class can then be used by the app to render an additional icon in front of the link.

Alternatives

Don't.

Additional Context

The app team needs to be informed when this issue is closed: https://issues.tuerantuer.org/browse/IGAPP-973
@svenseeberg svenseeberg added the 💡 feature New feature or request label Apr 1, 2022
@svenseeberg svenseeberg added this to the Version 1.3 milestone Apr 1, 2022
@timobrembeck timobrembeck added the ⁉️ prio: low Not urgent, can be resolved in the distant future. label Apr 1, 2022
@svenseeberg svenseeberg modified the milestones: Version 1.3, Backlog May 9, 2022
@svenseeberg svenseeberg changed the title Mark external links Mark external links, phone numbers, etc. May 17, 2022
@svenseeberg svenseeberg mentioned this issue May 17, 2022
Open
5 tasks
@svenseeberg svenseeberg modified the milestones: Backlog, 22Q4 Jun 7, 2022
@svenseeberg svenseeberg added ‼️ prio: high Needs to be resolved ASAP. 😱 effort: high Big change, which requires >12h and removed ⁉️ prio: low Not urgent, can be resolved in the distant future. labels Jun 7, 2022
@charludo charludo self-assigned this Oct 24, 2022
@charludo charludo mentioned this issue Oct 25, 2022
Merged
@charludo charludo linked a pull request Oct 25, 2022 that will close this issue
Mark external links with special class #1796
Merged
@timobrembeck timobrembeck mentioned this issue Nov 8, 2022
Merged
@jira-to-github-migrator jira-to-github-migrator bot mentioned this issue Aug 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charludo charludo

Labels
‼️ prio: high Needs to be resolved ASAP. 💡 feature New feature or request 😱 effort: high Big change, which requires >12h
Projects
None yet
Milestone
22Q4
Development

Successfully merging a pull request may close this issue.

Mark external links with special class digitalfabrik/integreat-cms
3 participants
@svenseeberg @timobrembeck @charludo