Mark external links with special class #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 71ccd22 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 74.2% (0.0% change). View more on Code Climate. |
svenseeberg
requested changes
Oct 26, 2022
integreat_cms/static/src/js/tinymce-plugins/custom_link_input/plugin.js
Outdated
Show resolved
Hide resolved
charludo
force-pushed
the
feature/mark-external-links
branch
2 times, most recently
from
a945c29
to
3578fbe
Compare
timobrembeck
requested changes
Oct 28, 2022
timobrembeck
requested changes
Oct 28, 2022
timobrembeck
approved these changes
Oct 28, 2022
charludo
force-pushed
the
feature/mark-external-links
branch
from
e0484a0
to
88b978d
Compare
charludo
force-pushed
the
feature/mark-external-links
branch
from
03f84b4
to
71ccd22
Compare
svenseeberg
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds the class
link-externalto links inserted or updated with TinyMCE.Proposed changes
integreat.app), if so, add extra class when insertingSide effects
Resolved issues
Fixes: #1333
Pull Request Review Guidelines