Don't show page fallback text if there is no alternative translation

[david-venhoff]

Short description

This pr prevents the fallback text for pages to be shown when the alternatives linklist would be empty.
This should fix a bug where the fallback text was shown for empty pages which are only used for the tree structure.

[codeclimate]

Code Climate has analyzed commit 1c3e1e0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.5% (0.0% change).

View more on Code Climate.

[svenseeberg]

@david-venhoff thanks a lot! Would you be willing to add a test case which returns the fall back text? AFAICT no test case currently returns the fall back translation. That would probably catch most related problems in the future.

[david-venhoff]

I've added a test case now (The fallback text is at line 426)

[svenseeberg]

Thanks a lot (again)! The change is minor, the test case added. Looks good to me ;)

[svenseeberg]

@timoludwig should we add an entry to the changelog?

[timobrembeck]

@timoludwig should we add an entry to the changelog?

Yes, sounds good 👍

[svenseeberg]

@david-venhoff as we do not have an issue for this, you can directly link to this PR. However, the normal link will mess with the build pipeline. But https://github.com/digitalfabrik/integreat-cms/issues/1417 does work as well as a link to PRs.