-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't show page fallback text if there is no alternative translation #1417
Conversation
Code Climate has analyzed commit 1c3e1e0 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 73.5% (0.0% change). View more on Code Climate. |
@david-venhoff thanks a lot! Would you be willing to add a test case which returns the fall back text? AFAICT no test case currently returns the fall back translation. That would probably catch most related problems in the future. |
ec14908
to
b7a7103
Compare
I've added a test case now (The fallback text is at line 426) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot (again)! The change is minor, the test case added. Looks good to me ;)
@timoludwig should we add an entry to the changelog? |
Yes, sounds good 👍 |
@david-venhoff as we do not have an issue for this, you can directly link to this PR. However, the normal link will mess with the build pipeline. But |
b7a7103
to
1c3e1e0
Compare
Short description
This pr prevents the fallback text for pages to be shown when the alternatives linklist would be empty.
This should fix a bug where the fallback text was shown for empty pages which are only used for the tree structure.