Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot submit feedback for fallback translation of recurring event #1858

Closed
sarahsporck opened this issue Nov 14, 2022 · 1 comment · Fixed by #1859
Closed

Cannot submit feedback for fallback translation of recurring event #1858

sarahsporck opened this issue Nov 14, 2022 · 1 comment · Fixed by #1859
Assignees
Labels
‼️ prio: high Needs to be resolved ASAP. 🐛 bug Something isn't working ☺️ effort: low Should be doable in <4h
Milestone

Comments

@sarahsporck
Copy link
Contributor

Describe the Bug

The pathname of a recurrent event contains the date of an explicit event (in the frontend).
E.g. https://webnext.integreat.app/testumgebung/de/events/spieleabend$2022-11-16
This pathname is provided by the backend.
However, the actual slug should not contain the date of the event. In the example above the slug is spieleabend.
It is possible to remove the date from the slug in the rontend but in fact this should probably be done in the backend. Either supply the event slug in the api, or make sending feedback with the slug containing the date work.

Steps to Reproduce

curl --location --request POST 'https://cms-test.integreat-app.de/testumgebung/ar/wp-json/extensions/v3/feedback/event' \
--form 'comment="asdf"' \
--form 'slug="spieleabend$2022-11-16"'

Expected Behavior

̀Submitting feedback works:
{"success": "Feedback successfully submitted"}

Actual Behavior

Submitting feedback fails with:
{"error": "No matching location found for slug."}

@sarahsporck sarahsporck added 🐛 bug Something isn't working ‼️ prio: high Needs to be resolved ASAP. ☺️ effort: low Should be doable in <4h labels Nov 14, 2022
@timobrembeck timobrembeck self-assigned this Nov 14, 2022
@timobrembeck timobrembeck changed the title Cannot submit feedback for recurring event Cannot submit feedback for fallback translation of recurring event Nov 14, 2022
@timobrembeck timobrembeck added this to the 22Q4 milestone Nov 14, 2022
@timobrembeck
Copy link
Member

Thanks for the report! This is essentially a combination of #1718 and #1793, so probably some conflicts between #1810 and #1811 were not correctly resolved...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
‼️ prio: high Needs to be resolved ASAP. 🐛 bug Something isn't working ☺️ effort: low Should be doable in <4h
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants