Fix fallback feedback for events and pois #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MizukiTemma
requested changes
Oct 27, 2022
timobrembeck
requested changes
Oct 27, 2022
|
Code Climate has analyzed commit 733d204 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 66.6% (50% is the threshold). This pull request will bring the total coverage in the repository to 74.2% (0.0% change). View more on Code Climate. |
david-venhoff
force-pushed
the
bugfix/fallback-feedback
branch
from
79d3977
to
56c71bf
Compare
timobrembeck
requested changes
Oct 28, 2022
Previously, an error was returned when the feedback was about a fallback translated object. Now, the default language gets used if required. The actual language of the feedback should not get lost, though. Co-authored-by: Timo Ludwig <ludwig@integreat-app.de>
david-venhoff
force-pushed
the
bugfix/fallback-feedback
branch
from
56c71bf
to
733d204
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This pr fixes submitting feedback about a fallback page- or poi-translation. With this pr, the default language translation gets used if required.
The actual language of the feedback should not get lost, though.
Proposed changes
Resolved issues
Fixes: #1718
Pull Request Review Guidelines