Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make items in the sidebar of content forms expandable and save the setting as a cookie #1876

Closed
4 tasks done
Tracked by #1769
ulliholtgrave opened this issue Nov 18, 2022 · 5 comments · Fixed by #1972
Closed
4 tasks done
Tracked by #1769
Assignees
Labels
🍼 good first issue Good for newcomers 💡 feature New feature or request ❗ prio: medium Should be scheduled in the forseeable future. ☺️ effort: low Should be doable in <4h
Milestone

Comments

@ulliholtgrave
Copy link
Member

ulliholtgrave commented Nov 18, 2022

Motivation

Right now our content forms (e.g. page form) are pretty stuffed with elements and the design team is working on it. However, as a quick fix and considering the additonal SEO, HIX and AT section we want to reduce the elements ASAP.

Proposed Solution

Make the sidebar and SEO section expandable and save the last setting in a cookie to load it if the user returns to that view.

  • Page form
  • Event form
  • POI form

This blocks:

@ulliholtgrave ulliholtgrave added 💡 feature New feature or request 🍼 good first issue Good for newcomers ❗ prio: medium Should be scheduled in the forseeable future. ☺️ effort: low Should be doable in <4h labels Nov 18, 2022
@ulliholtgrave ulliholtgrave added this to the 22Q4 milestone Nov 18, 2022
@ulliholtgrave ulliholtgrave changed the title Make sidebar of content forms expendable and save the setting as a cookie Make sidebar of content forms expandable and save the setting as a cookie Nov 18, 2022
@svenseeberg
Copy link
Member

svenseeberg commented Nov 18, 2022

Is this about collapsing the full sidebar (to the right) or single boxes within the sidebar (by rolling them up)?

I think it would be better to collapse single boxes. And the default could differ depending on the expert role.

@ulliholtgrave
Copy link
Member Author

I guess as we are not even showing all items to non-expert users I wouldn't really go with a role-based view.

In my opinion we should add an expandable option to all 5 boxes on the right side as some of them (e.g. Settings of the page) aren't really used that often. I wouldn't mind providing expanding on a more granular level, but as a quick fix I would start with the big boxes.

@svenseeberg
Copy link
Member

Okay, I guess we agree that this is about collapsing single boxes.

@ulliholtgrave
Copy link
Member Author

Ahh yeah, right. I misunderstood your last statement. I will adjust the title of issue.

@ulliholtgrave ulliholtgrave changed the title Make sidebar of content forms expandable and save the setting as a cookie Make items in the sidebar of content forms expandable and save the setting as a cookie Nov 18, 2022
@JoeyStk JoeyStk self-assigned this Nov 22, 2022
@timobrembeck timobrembeck modified the milestones: 22Q4, 23Q1 Dec 12, 2022
@timobrembeck
Copy link
Member

This was fixed in #1972

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍼 good first issue Good for newcomers 💡 feature New feature or request ❗ prio: medium Should be scheduled in the forseeable future. ☺️ effort: low Should be doable in <4h
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants