Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new design to automatically translate a page into selected target languages #1923

Closed
Tracked by #1928 ...
JoeyStk opened this issue Nov 30, 2022 · 8 comments
Closed
Tracked by #1928 ...
Labels
🚫 wontfix This will not be worked on

Comments

@JoeyStk
Copy link
Contributor

JoeyStk commented Nov 30, 2022

Motivation

We want to enable automatic translations for pages, combined with a new design. With this issue the translation page tree should be extended and the option to automatically translate a page into one target language should be introduced.

Proposed Solution

Add option to translate a page into one or more target language following the new design.
On clicking into the selection field, a multi-select dropdown should open with checkboxes (?) for each language.

Alternatives

None

Additional Context

This issue depends on #1727

language
Source

Selection Translation Confirmation
Screenshot 2022-12-01 at 16-11-27 Figma Screenshot 2022-12-01 at 16-12-00 Figma Screenshot 2022-12-01 at 16-12-14 Figma
@JoeyStk JoeyStk added 💡 feature New feature or request ‼️ prio: high Needs to be resolved ASAP. labels Nov 30, 2022
@JoeyStk JoeyStk added this to the 23Q1 milestone Nov 30, 2022
@timobrembeck timobrembeck added the ⛔ blocked Blocked by external dependency label Nov 30, 2022
@osmers
Copy link

osmers commented Dec 1, 2022

Between the "one language" and "all languages (issue #1924)" there should be the option to translate more than one, but not all (so choosing specific languages). The best would be, imho, to have a drop down with boxes that I can tick, for all available languages in the feature you are building in this issue. So that after ticking the languages I want, all chosen languages are shown in the drop down field (where right now there is Ukrainisch or Englisch in the picture above)

@timobrembeck timobrembeck changed the title Add new design to automatically translate a page into one target language Add new design to automatically translate a page into selected target languages Dec 1, 2022
@timobrembeck
Copy link
Member

Alright. I update the issue description. Nevertheless, since this feature is very complex, I suggest we wait until the requirements are settled between the service team and the UI/UX team before implementing this.

@timobrembeck timobrembeck removed the ‼️ prio: high Needs to be resolved ASAP. label Dec 1, 2022
@timobrembeck timobrembeck modified the milestones: 23Q1, Backlog Dec 1, 2022
@osmers
Copy link

osmers commented Dec 12, 2022

I have a meeting with Nikola today - maybe afterwards things are clearer.

@osmers
Copy link

osmers commented Feb 6, 2023

@nikolahoff has already designed the new page tree for the translation section with the drop down for language selection - is there other information that you'd need @timoludwig ?

@osmers
Copy link

osmers commented Feb 6, 2023

Checked with @dkehne and Nikola's design is ok - could you maybe update it in the description of the issue?

@timobrembeck
Copy link
Member

Ok, I updated the issue... But I still have a few concerns with this new design, e.g.:

  • Why are there no checkboxes for each line? Is there only the possibility to translate each chapter at once, without the ability to translate two chapters or only sub-chapters/specific pages?
  • Why is there exactly one language selection widget per page? I think in most cases, I want to translate multiple pages into the same set of languages, right? Isn't it quite cumbersome to select e.g. 4 specific languages for 20 different pages (so at least 100 clicks for this task)? Why not selecting one language-combination for all pages which are currently selected for translation? Am I missing something, or is this really the desired workflow?

I mean we can surely implement this approach and improve on it later on, but please be aware that these are complex changes and we will waste a lot of time if we implement something that isn't usable in the end.

@timobrembeck timobrembeck added ❗ prio: medium Should be scheduled in the forseeable future. 😱 effort: high Big change, which requires >12h and removed ⛔ blocked Blocked by external dependency labels Feb 7, 2023
@timobrembeck timobrembeck modified the milestones: Backlog, 23Q2 Feb 7, 2023
@osmers
Copy link

osmers commented Feb 7, 2023

As far as I understood the design, it's exactly the same page tree as under pages and for each page you can choose the languages - you are right that if I want to translate multiple pages into the same languages, it is really cumbersome. I discussed the same with Daniel and basically we'd need a bulk action for that (which I thought already exists/is planned?). Also, if we add a new language, there should be a bulk action somewhere to translate all pages/selected pages to the new language.

The use I see for this translation section is that I can quickly check the translation status of all pages and then select for each page, which languages need to be updated. Sometimes the status is quite messy.

E.g. here:
image

It's not always all the same languages for all pages.

I think the cases we will have are (in the order of occurence):

  • the update of already existing translations (via the page form)
  • translation of new page into all/selected languages (translation section)
  • translation of all pages into a newly added language (bulk action)

@osmers
Copy link

osmers commented Feb 7, 2023

@timoludwig just talked to @JoeyStk and I think now I know what you mean with the check boxes - you are right, I think those need to be added to be able to carry out bulk actions

@JoeyStk JoeyStk closed this as completed Mar 6, 2023
@JoeyStk JoeyStk closed this as not planned Won't fix, can't repro, duplicate, stale Mar 6, 2023
@timobrembeck timobrembeck added 🚫 wontfix This will not be worked on and removed 💡 feature New feature or request ❗ prio: medium Should be scheduled in the forseeable future. 😱 effort: high Big change, which requires >12h labels Mar 6, 2023
@timobrembeck timobrembeck removed this from the 23Q2 milestone Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚫 wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants