Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor edit field not changed after XLIFF import #1934

Closed
timobrembeck opened this issue Dec 5, 2022 · 3 comments · Fixed by #1935
Closed

Minor edit field not changed after XLIFF import #1934

timobrembeck opened this issue Dec 5, 2022 · 3 comments · Fixed by #1935
Assignees
Labels
🐛 bug Something isn't working ☺️ effort: low Should be doable in <4h 🆘 prio: urgent Needs to be resolved now(?)
Milestone

Comments

@timobrembeck
Copy link
Member

Describe the Bug

When the newest version of a translation is a minor edit and this page is imported as XLIFF, the minor_edit field is set even after the import, meaning the translation status does not change.

Steps to Reproduce

  1. Create latest version with minor edit in target language
  2. Export as XLIFF and re-import without changes
  3. Confirm
  4. See translation status still outdated

Expected Behavior

An XLIFF import should never be considered a minor edit and always cause the page to be up to date after import

Actual Behavior

The translation status stays outdated when latest version is minor edit

Additional Information

@timobrembeck timobrembeck added 🐛 bug Something isn't working ☺️ effort: low Should be doable in <4h 🆘 prio: urgent Needs to be resolved now(?) labels Dec 5, 2022
@timobrembeck timobrembeck added this to the 22Q4 milestone Dec 5, 2022
@svenseeberg
Copy link
Member

I have not yet spent time investigating the cause of #1914 - they could be related.

@timobrembeck timobrembeck self-assigned this Dec 5, 2022
@timobrembeck
Copy link
Member Author

I have not yet spent time investigating the cause of #1914 - they could be related.

I think they are related from their topic, but require different solutions. I already have an idea, should I take over #1914 as well?

@timobrembeck
Copy link
Member Author

Also, #1871 is related but a different problem I think (since in that case the publication status is different, not the minor edit field)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working ☺️ effort: low Should be doable in <4h 🆘 prio: urgent Needs to be resolved now(?)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants