Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure translations are never a minor version after XLIFF import #1935

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

timobrembeck
Copy link
Member

Short description

Make sure translations are never a minor version after XLIFF import

Proposed changes

  • When deserializing XLIFF files, always reset the minor edit field to False, independently of whether the existing database object is a minor or major edit.

Resolved issues

Fixes: #1934


Pull Request Review Guidelines

@timobrembeck timobrembeck requested a review from a team as a code owner December 5, 2022 20:39
Copy link
Member

@svenseeberg svenseeberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution definitely ensures that this can never happen again :D

Copy link
Member

@david-venhoff david-venhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@timobrembeck timobrembeck merged commit f010eb6 into develop Dec 6, 2022
@timobrembeck timobrembeck deleted the bugfix/minor-edit-xliff-import branch December 6, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor edit field not changed after XLIFF import
3 participants