Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only allow staff members to use SUMM.AI bulk action #2065

Closed
Tracked by #1928
timobrembeck opened this issue Feb 13, 2023 · 2 comments · Fixed by #2104
Closed
Tracked by #1928

Only allow staff members to use SUMM.AI bulk action #2065

timobrembeck opened this issue Feb 13, 2023 · 2 comments · Fixed by #2104
Assignees
@JoeyStk
Labels
🍼 good first issue Good for newcomers 💡 feature New feature or request ⁉️ prio: low Not urgent, can be resolved in the distant future. ☺️ effort: low Should be doable in <4h
Milestone
23Q1

Comments

@timobrembeck
Copy link
Member

Motivation

We only use the SUMM.AI bulk action in the page tree for initial translations by our team.
Thus, it should also be limited to staff members.
Region managers are supposed to translate pages in SUMM.AI via the new machine translation interface (#1727).

Proposed Solution

  • Either check is_staff in the bulk action view or create a new permission and assign it to the service- and cms team
  • Hide bulk action for users who are not allowed to use it
@timobrembeck timobrembeck added 💡 feature New feature or request 🍼 good first issue Good for newcomers ‼️ prio: high Needs to be resolved ASAP. ☺️ effort: low Should be doable in <4h labels Feb 13, 2023
@timobrembeck timobrembeck added this to the 23Q1 milestone Feb 13, 2023
This was referenced Feb 13, 2023
Open
Merged
@JoeyStk JoeyStk added ⁉️ prio: low Not urgent, can be resolved in the distant future. and removed ‼️ prio: high Needs to be resolved ASAP. labels Feb 17, 2023
@JoeyStk
Copy link
Contributor

JoeyStk commented Feb 17, 2023

As a work-around the function was disabled, therefore this issue isn't prio high anymore

@JoeyStk JoeyStk self-assigned this Mar 1, 2023
@JoeyStk JoeyStk mentioned this issue Mar 6, 2023
Merged
@timobrembeck
Copy link
Member Author

Doesn't this issue contradict our decision to cancel the automatic translation page tree (see #1727)? If we don't have the other automatic translation interface, then normal users should be able to use the bulk action, otherwise they don't have the possibility to translate at all...

@timobrembeck timobrembeck mentioned this issue Mar 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoeyStk JoeyStk

Labels
🍼 good first issue Good for newcomers 💡 feature New feature or request ⁉️ prio: low Not urgent, can be resolved in the distant future. ☺️ effort: low Should be doable in <4h
Projects
None yet
Milestone
23Q1
Development

Successfully merging a pull request may close this issue.

Only allow staff members to use the SUMM AI bulk action digitalfabrik/integreat-cms
2 participants
@timobrembeck @JoeyStk