Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archiving mirrored pages causes inconsistent state #2171

Closed
timobrembeck opened this issue Mar 27, 2023 · 0 comments · Fixed by #2329
Closed

Archiving mirrored pages causes inconsistent state #2171

timobrembeck opened this issue Mar 27, 2023 · 0 comments · Fixed by #2329
Assignees
Labels
🐛 bug Something isn't working ❗ prio: medium Should be scheduled in the forseeable future. 😅 effort: medium Should be doable in <12h
Milestone

Comments

@timobrembeck
Copy link
Member

Describe the Bug

When a page, that is mirrored on another page, is archived, this leads to several problems:

  1. The mirrored page is not selected in the dropdown anymore (because archived pages are removed from the queryset of possible mirroring targets), which means the first page of that region becomes the mirroring target when the save button is clicked, which is easily overlooked and means potentially unrelated content is inserted as live content
  2. The content of the archived mirrored page is still live somewhere, which contradicts the purpose of archiving a page

Steps to Reproduce

  1. Mirror a page somewhere
  2. Archive the mirrored page

Expected Behavior

Either one of two things should happen:

  1. Archiving a mirrored page should not be possible, similar to deleting a mirrored page
  2. The live content should be disabled when a mirrored page is archived (in this case we could also allow deleting a page with the same effect)

Actual Behavior

The mirrored page is archived, but still referenced as live content

@timobrembeck timobrembeck added 🐛 bug Something isn't working ❗ prio: medium Should be scheduled in the forseeable future. 😅 effort: medium Should be doable in <12h labels Mar 27, 2023
@timobrembeck timobrembeck added this to the 23Q2 milestone Mar 27, 2023
@MizukiTemma MizukiTemma self-assigned this Jul 1, 2023
@timobrembeck timobrembeck modified the milestones: 23Q2, 23Q3 Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working ❗ prio: medium Should be scheduled in the forseeable future. 😅 effort: medium Should be doable in <12h
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants