Do not archive mirrored pages

[MizukiTemma]

Short description

This PR solves the inconsistent state of mirrored pages by prevanting archiving of mirrored pages.

Proposed changes

• Deactivate the archiving icon of mirrored pages in the tree
• Hide the archiving button in the form if the page is mirrored
• Check if there are mirorring pages before archiving a page (both in single request and bulk action)
• Adjust error/success messages of the bulk action and titles of the icon

Side effects

• None?
• I have chosen the first one among the two suggested solutions (expected behaviour) because it seems to be more in accordance with the existing behaviour of page deletion and probably causes less confusion than the second option.

Resolved issues

Fixes: #2171

---

Pull Request Review Guidelines

[codeclimate]

Code Climate has analyzed commit 076d180 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 86.6% (50% is the threshold).

This pull request will bring the total coverage in the repository to 76.3%.

View more on Code Climate.

[timobrembeck]

Thanks a lot, works as expected! 💪

I thought that maybe it could be helpful to know which pages prevent the page from being archived, so in case they want to proceed they can e.g. contact the manager of the other region to remove the live content etc...

[MizukiTemma]

@timoludwig In the action box it shows where the page is mirrored. I'll modify the explanation a bit.

Update: now the warning with a list of mirroring pages is shown both for archiving and deletion. If a page is only mirrored and does not have any child pages (another reason deletion will be deactivated), the warning is shown doubled, though I hope this is not so tragic and rather helps user as explizit explanation.

[timobrembeck]

Cool, thanks! 👍

[svenseeberg]

I'm a little worried that some regions have to maintain pages because other regions do mirror them. Can we think of a solution here? Maybe a button to remove all mirror pages by force from the source region and notify the maintainers via mail?

[MizukiTemma]

That's a nice idea 😃 @osmers What way do you think is the best to inform content creators that a mirrored page has been removed if we introduce force archiving/deleting of mirrored pages? I have a bit of worry that not all of them check E-mails...

Though I would make it a separate issur.

[david-venhoff]

Looks good to me. As a small suggestion, you might consider to move the is mirrored checks into the page.archive() method, to reduce code duplication. I don't think this is blocking the pr though.

[MizukiTemma]

As a small suggestion, you might consider to move the is mirrored checks into the page.archive() method, to reduce code duplication. I don't think this is blocking the pr though.

Nice idea, though I'll leave the code as it is to keep the current check & message schema and to avoid bulk archive action getting inturruped at the first mirrored page 🙂

[osmers]

@MizukiTemma good question - I think generally they are registered with their work account and should therefore read the emails. Maybe you can also always send an email to me so that I am aware and can inform the corresponding person from the service team to double check with the municipality.
I just had the issue as well that I need to archive the corona pages but can't bcs they are mirrored in many regions.
Did you introduce a solution already or not yet?

[MizukiTemma]

@osmers Thank you for feedback! This notification function is not yet implemented. I have updated the issue for that #2338

[osmers]

@MizukiTemma at the same time I noticed that archived pages are also shown as mirroring a page and created an issue for that bcs only live pages should be in the list. Otherwise people would get notified that content has been removed even though they already archived the page that had the removed content.

[MizukiTemma]

@osmers Thank you for report and creating the issue!