Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback texts of mirrored pages list empty pages #2172

Closed
timobrembeck opened this issue Mar 27, 2023 · 0 comments · Fixed by #2379
Closed

Fallback texts of mirrored pages list empty pages #2172

timobrembeck opened this issue Mar 27, 2023 · 0 comments · Fixed by #2379
Assignees
@MizukiTemma
Labels
🐛 bug Something isn't working ⁉️ prio: low Not urgent, can be resolved in the distant future. ☺️ effort: low Should be doable in <4h
Milestone
23Q3

Comments

@timobrembeck
Copy link
Member

Describe the Bug

When a mirrored content is not available in the current language, we show a partial fallback text.
This is also shown when the referenced translation is empty, which makes no sense.

Steps to Reproduce

  1. Create an empty page
  2. Reference another empty page as live content
  3. Inspect page_translation.mirrored_translation_text_or_fallback_message

Expected Behavior

Empty translations should not be listed as fallback translations of mirrored pages

Actual Behavior

All available languages are listed, even those with empty translations
@timobrembeck timobrembeck added 🐛 bug Something isn't working ⁉️ prio: low Not urgent, can be resolved in the distant future. ☺️ effort: low Should be doable in <4h labels Mar 27, 2023
@timobrembeck timobrembeck added this to the 23Q2 milestone Mar 27, 2023
@timobrembeck timobrembeck modified the milestones: 23Q2, 23Q3 Jul 2, 2023
@MizukiTemma MizukiTemma self-assigned this Jul 31, 2023
@MizukiTemma MizukiTemma mentioned this issue Jul 31, 2023
Merged
@ulliholtgrave ulliholtgrave mentioned this issue Sep 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MizukiTemma MizukiTemma

Labels
🐛 bug Something isn't working ⁉️ prio: low Not urgent, can be resolved in the distant future. ☺️ effort: low Should be doable in <4h
Projects
None yet
Milestone
23Q3
Development

Successfully merging a pull request may close this issue.

Do not show empty mirrored content as fallback digitalfabrik/integreat-cms
2 participants
@timobrembeck @MizukiTemma