Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not show empty mirrored content as fallback #2379

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Do not show empty mirrored content as fallback #2379

merged 1 commit into from
Aug 7, 2023

Conversation

MizukiTemma
Copy link
Member

@MizukiTemma MizukiTemma commented Jul 31, 2023 •
edited

Short description

This PR fixes the bug that not only non-empty translations but also empty translasions are suggested as fallback of the embedded content.

Proposed changes

  • Filter empty translations out of the fallback list
  • Return an empty string as in the case where the page has no mirrored content, if there is no non-empty translations which can be a fallback. (Otherwise no language will be shown after the message Part of the page does not exist in the selected language. It is however available in these languages: and it is confusing.)

Side effects

  • I may have misunderstood some part of the functionalitry and/or the wished status 馃檲

Resolved issues

Fixes: #2172

Pull Request Review Guidelines

@MizukiTemma MizukiTemma requested a review from a team as a code owner July 31, 2023 14:45
@codeclimate
Copy link

codeclimate bot commented Jul 31, 2023 •
edited

Code Climate has analyzed commit 14e7bd3 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 76.3% (0.0% change).

View more on Code Climate.

david-venhoff
david-venhoff approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@david-venhoff david-venhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ulliholtgrave
ulliholtgrave approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@ulliholtgrave ulliholtgrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, This seems to do the trick 馃憤

@MizukiTemma MizukiTemma merged commit 7fb10c3 into develop Aug 7, 2023
5 checks passed
@MizukiTemma MizukiTemma deleted the bug/fallback_text branch August 7, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulliholtgrave ulliholtgrave ulliholtgrave approved these changes

@david-venhoff david-venhoff david-venhoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fallback texts of mirrored pages list empty pages
3 participants
@MizukiTemma @ulliholtgrave @david-venhoff