Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New API URL patterns not versioned #2290

Closed
timobrembeck opened this issue May 17, 2023 · 1 comment · Fixed by #2617
Closed

New API URL patterns not versioned #2290

timobrembeck opened this issue May 17, 2023 · 1 comment · Fixed by #2617
Assignees
@sarahsporck
Labels
🐛 bug Something isn't working ⁉️ prio: low Not urgent, can be resolved in the distant future. ☺️ effort: low Should be doable in <4h
Milestone
24Q1

Comments

@timobrembeck
Copy link
Member

Describe the Bug

At the moment, we only add the version number v3 for the legacy API endpoint patterns from wordpress, but not for the new ones.
On order for the app to migrate to the new patterns, we need to prefix them with the current version.

Steps to Reproduce

  1. Go to http://localhost:8000/api/regions/
  2. See API result

Expected Behavior

The API result should be available under http://localhost:8000/api/v3/regions/

Actual Behavior

There is no version parameter
@timobrembeck timobrembeck added 🐛 bug Something isn't working ⁉️ prio: low Not urgent, can be resolved in the distant future. ☺️ effort: low Should be doable in <4h labels May 17, 2023
@timobrembeck timobrembeck added this to the Backlog milestone May 17, 2023
@steffenkleinle
Copy link
Member

Please notify the app team once this is done: https://issues.tuerantuer.org/browse/IGAPP-1317

@jira-to-github-migrator jira-to-github-migrator bot mentioned this issue Aug 12, 2023
Open
@timobrembeck timobrembeck modified the milestones: Backlog, 24Q1 Jan 10, 2024
@sarahsporck sarahsporck self-assigned this Jan 23, 2024
@sarahsporck sarahsporck mentioned this issue Jan 23, 2024
Merged
@timobrembeck timobrembeck mentioned this issue Feb 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarahsporck sarahsporck

Labels
🐛 bug Something isn't working ⁉️ prio: low Not urgent, can be resolved in the distant future. ☺️ effort: low Should be doable in <4h
Projects
None yet
Milestone
24Q1
3 participants
@timobrembeck @sarahsporck @steffenkleinle