Add version to api url patterns #2617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit eb426ac and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 80.5% (0.0% change). View more on Code Climate. |
MizukiTemma
approved these changes
Jan 23, 2024
Jep. You're totally right! I've updated the docs. |
timobrembeck
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Thanks a lot! 👍
Once we have more than one active API version, we might need to reflect this in our package structure as well (similar to how we did it for lunes-cms), but since we aren't planning v4 yet, I guess it's not necessary to do the extra work now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds a version path element to the new endpoints, so that the app & webapp can finally use them.
Proposed changes
Side effects
Resolved issues
Fixes: #2290
Pull Request Review Guidelines