Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View tests not working #552

Closed
Tracked by #765
timobrembeck opened this issue Oct 22, 2020 · 0 comments · Fixed by #553
Closed
Tracked by #765

View tests not working #552

timobrembeck opened this issue Oct 22, 2020 · 0 comments · Fixed by #553
Assignees
@timobrembeck
Labels
🐛 bug Something isn't working ❗ prio: medium Should be scheduled in the forseeable future.
Milestone
Stable release

Comments

@timobrembeck
Copy link
Member

Describe the Bug

At the moment, the view tests are not working properly. In theory, bug #549 should be detected by the view test but it doesn't.

Steps to Reproduce

  1. Run tests

Expected Behavior

Since bug #549 exists, the tests should not succeed.

Actual Behavior

The tests run without errors.

Additional Information

I assume that late binding (see e.g. here) might be responsible for this. Instead of all urls, only the last given url is actually tested in test_function().
@timobrembeck timobrembeck added 🐛 bug Something isn't working ❗ prio: medium Should be scheduled in the forseeable future. labels Oct 22, 2020
@timobrembeck timobrembeck added this to the Feature Completion milestone Oct 22, 2020
@timobrembeck timobrembeck self-assigned this Oct 22, 2020
timobrembeck added a commit that referenced this issue Oct 22, 2020
@timobrembeck
Fix view tests (fixes #552)
787a6f0 
Prevent late binding of the url parameter in test functions by setting an explicit default parameter
@timobrembeck timobrembeck mentioned this issue Oct 22, 2020
Merged
@timobrembeck timobrembeck mentioned this issue Nov 3, 2022
Open
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timobrembeck timobrembeck

Labels
🐛 bug Something isn't working ❗ prio: medium Should be scheduled in the forseeable future.
Projects
None yet
Milestone
Stable release
Development

Successfully merging a pull request may close this issue.

Fix view tests digitalfabrik/integreat-cms
1 participant
@timobrembeck