Add bulk actions to POIs and events #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeyStk
force-pushed
the
feature/bulk_action
branch
from
2ac6f5e
to
d629727
Compare
ulliholtgrave
requested changes
Jan 19, 2022
JoeyStk
force-pushed
the
feature/bulk_action
branch
2 times, most recently
from
3c582b4
to
9a2e8f3
Compare
There was a problem hiding this comment.
Thanks! 🚀
See my comments below for a few minor improvements.
One additional problem I noticed: The bulk action form interferes with the duplication forms for events, I'm afraid we have to find some workaround for this. In theory, I don't think nested forms are allowed in HTML 😒
JoeyStk
force-pushed
the
feature/bulk_action
branch
3 times, most recently
from
f5a55c3
to
0ad4aa2
Compare
JoeyStk
force-pushed
the
feature/bulk_action
branch
from
3f52223
to
fb5079e
Compare
JoeyStk
force-pushed
the
feature/bulk_action
branch
from
d2edf32
to
74789ec
Compare
timobrembeck
force-pushed
the
feature/bulk_action
branch
from
3e9f513
to
d04a7bd
Compare
Co-authored-by: Timo Ludwig <ludwig@integreat-app.de>
timobrembeck
approved these changes
Jan 19, 2022
timobrembeck
changed the title
|
@ulliholtgrave I think you have to approve as well, or at least somehow delete your "changes requested" status in order for this PR to be merged ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Add checkboxes to pois and events, add option to auto translate
Proposed changes
Add the dropdown from posts to events and pois using the existing bulk action template.
Resolved issues
Fixes: #1103
Addition information
This is part of the project for Johannes' final exam.