Enable deletion of languages and offer templates #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenseeberg
previously requested changes
Feb 10, 2022
timobrembeck
force-pushed
the
enhancement/deletions
branch
from
185834e
to
fc3cb30
Compare
Merged
ulliholtgrave
approved these changes
Feb 11, 2022
There was a problem hiding this comment.
Looks good to me. @svenseeberg I guess it's fine if the superuser to have the permission to delete languages for now
ulliholtgrave
dismissed
svenseeberg’s stale review
I guess it's fine for now that only superuser can delete languages. I follow timo's approach that we could redo the permissions in a future refactoring, but for the migration this should be fine :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR contains a few small improvements and adds the possibility to delete languages and offer templates
Proposed changes
Resolved issues
Fixes: #1143
Fixes: #1151
Fixes: #1106