Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix POI integration in event form and list #1174

Merged
merged 3 commits into from
Feb 16, 2022
Merged

Fix POI integration in event form and list #1174

merged 3 commits into from
Feb 16, 2022

Conversation

timobrembeck
Copy link
Member

Short description

This fixes a few problems with POIs in the event form and list

Proposed changes

  • Fix filtering for locations in event list
  • Redesign POI selection in event form
  • Do not preselect unused location for new event

Resolved issues

Fixes: #1166
Fixes: #1172
Fixes: #1173

@timobrembeck timobrembeck requested a review from a team as a code owner February 15, 2022 14:51
ulliholtgrave
ulliholtgrave approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@ulliholtgrave ulliholtgrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice and works as expected 👍 Thanks :)

@timobrembeck timobrembeck merged commit 4027ebc into develop Feb 16, 2022
@timobrembeck timobrembeck deleted the bugfix/poi-creation-event-form branch February 16, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulliholtgrave ulliholtgrave ulliholtgrave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@timobrembeck @ulliholtgrave