Show empty tag if the page has no subpages #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks a lot! 👍
Could you add a small note to the changelog for the empty page tag?
The bug with drag & drop doesn't need an entry in the changelog, it was introduced in the current unreleased version, so it is not a real change in comparison to the last version.
david-venhoff
force-pushed
the
feature/page_tag_improvement
branch
from
bd23424
to
b190a87
Compare
|
Added the note 👍 |
timobrembeck
approved these changes
Feb 19, 2022
There was a problem hiding this comment.
🎉
Also, should this pr close #1175?
No, I think it's good to leave it open as reference and add a note that it's blocked by the other issue.
svenseeberg
changed the title
|
I think the title of this PR is misleading 😅 We're not showing the empty tag if a page has children OR has no children and is empty. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This pr hides the empty for a page if the page has no subpages.
Generally, this tag should be hidden if the page has no publicly visible subpages, however this is not implemented as part of this pr.
This work should be done together with #1158.
Additionally, this pr fixes a crash due to an invalid url when moving a page.
Partially solves: #1175
Proposed changes