Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix page filter form #1304

Merged
merged 2 commits into from
Mar 17, 2022
Merged

Fix page filter form #1304

merged 2 commits into from
Mar 17, 2022

Conversation

timobrembeck
Copy link
Member

Short description

Fix page tree after resetting filters

Proposed changes

  • Refactor page filter form
  • Add page filter tests

Resolved issues

Fixes: #1296

@timobrembeck timobrembeck requested a review from a team as a code owner March 16, 2022 14:19
@timobrembeck timobrembeck force-pushed the bugfix/page-tree-filters branch 2 times, most recently from 02a88bb to 41ad3e1 Compare March 16, 2022 16:03
Copy link
Member

@ulliholtgrave ulliholtgrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Works as expected! :)

- The problem with the broken tree no longer exists
- This reverts commit 67e76b8
@codeclimate
Copy link

codeclimate bot commented Mar 17, 2022

Code Climate has analyzed commit 0e2b49c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.2% (0.2% change).

View more on Code Climate.

@timobrembeck timobrembeck merged commit 1868f16 into develop Mar 17, 2022
@timobrembeck timobrembeck deleted the bugfix/page-tree-filters branch March 17, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page tree broken after search is cleared
2 participants