Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of root pages #1355

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Fix order of root pages #1355

merged 1 commit into from
Apr 13, 2022

Conversation

timobrembeck
Copy link
Member

Short description

Fix order of root pages

Proposed changes

  • Order root pages by the tree_id instead of the lft field

Resolved issues

Fixes: #1354

@timobrembeck timobrembeck requested a review from a team as a code owner April 12, 2022 12:32
@codeclimate
Copy link

codeclimate bot commented Apr 12, 2022

Code Climate has analyzed commit c0b0ee5 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.1%.

View more on Code Climate.

Copy link
Member

@ulliholtgrave ulliholtgrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👍

@timobrembeck timobrembeck merged commit a198d11 into develop Apr 13, 2022
@timobrembeck timobrembeck deleted the bugfix/page-order branch April 13, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order field in page API not working on root level
2 participants