Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve regions #1412

Merged
merged 3 commits into from
May 10, 2022
Merged

Improve regions #1412

merged 3 commits into from
May 10, 2022

Conversation

timobrembeck
Copy link
Member

Short description

A few improvements and fixes for regions

Proposed changes

  • Fix automatic filling of region coordinates
  • Add location setting to region model
  • Use three-column layout for region form

Resolved issues

Fixes: #1407
Fixes: #1409

@timobrembeck timobrembeck requested a review from a team as a code owner May 10, 2022 12:53
@codeclimate
Copy link

codeclimate bot commented May 10, 2022

Code Climate has analyzed commit 57909d0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 50.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.5%.

View more on Code Climate.

ulliholtgrave
ulliholtgrave approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@ulliholtgrave ulliholtgrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, works as expected 👍

@timobrembeck timobrembeck merged commit db1f9a2 into develop May 10, 2022
@timobrembeck timobrembeck deleted the bugfix/regions branch May 10, 2022 14:22
@timobrembeck timobrembeck mentioned this pull request May 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulliholtgrave ulliholtgrave ulliholtgrave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filling region coordinates not working anymore Add location setting to region model
2 participants
@timobrembeck @ulliholtgrave