Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also duplicate imprint during duplication process and remove token duplication #1419

Merged
merged 2 commits into from
May 12, 2022

Conversation

ulliholtgrave
Copy link
Member

Short description

This PR adds the duplication of the imprint to the duplication process and stops the duplication of the api token for pages.

Resolved issues

Fixes: #1402
Fixes #1408

@ulliholtgrave ulliholtgrave requested a review from a team as a code owner May 11, 2022 23:19
@ulliholtgrave ulliholtgrave changed the title Also duplicate imprint during duplication process Also duplicate imprint during duplication process and remove token duplication May 11, 2022
@codeclimate
Copy link

codeclimate bot commented May 11, 2022

Code Climate has analyzed commit 684025f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.6% (0.0% change).

View more on Code Climate.

Copy link
Member

@timobrembeck timobrembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, works as expected! 👍

CHANGELOG.md Show resolved Hide resolved
integreat_cms/cms/forms/regions/region_form.py Outdated Show resolved Hide resolved
@ulliholtgrave ulliholtgrave merged commit c462632 into develop May 12, 2022
@ulliholtgrave ulliholtgrave deleted the feature/imprint_duplication branch May 12, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clone region copies API token Imprint does not get duplicated during region duplication process
2 participants