API: slugify page slugs, fixes #1401 #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
... tests proved this wrong. I'll take another look ;-) |
|
Code Climate has analyzed commit a870052 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 73.5% (0.0% change). View more on Code Climate. |
svenseeberg
force-pushed
the
feature/api-page-slugify
branch
from
8b18137
to
714cde7
Compare
* Apply the slugify function on all API page endpoint slugs. Co-authored-by: Timo Ludwig <ludwig@integreat-app.de>
svenseeberg
force-pushed
the
feature/api-page-slugify
branch
from
714cde7
to
a870052
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Apply the slugify function on all API page endpoint slugs. This should make all calls to children endpoints compatible with old WordPress slugs. This should do no harm (except of some compute time), as we only have slugs in our database that were cleaned by the slugify function.
Proposed changes
Use the slugify function to clean page translation slugs in API requests.
Resolved issues
Fixes: #1401