Add bulk action for multilingual XLIFF export #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 1b950a2 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 57.8% (50% is the threshold). This pull request will bring the total coverage in the repository to 74.1% (0.0% change). View more on Code Climate. |
membralala
force-pushed
the
feature/bundle-xliff
branch
from
4635e01
to
7980cf1
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
timobrembeck
reviewed
Aug 5, 2022
integreat_cms/cms/templates/pages/_page_xliff_export_overlay.html
Outdated
Show resolved
Hide resolved
integreat_cms/cms/templates/pages/_page_xliff_export_overlay.html
Outdated
Show resolved
Hide resolved
integreat_cms/cms/templates/pages/_page_xliff_export_overlay.html
Outdated
Show resolved
Hide resolved
|
Thanks for your feedback! I changed the behaviour based on your suggestions and I think you're right, it feels a bit more natural this way. Does this match your expectations as well? 🙂 |
timobrembeck
reviewed
Aug 9, 2022
integreat_cms/cms/templates/pages/_page_xliff_export_overlay.html
Outdated
Show resolved
Hide resolved
membralala
force-pushed
the
feature/bundle-xliff
branch
from
16c1fe4
to
c0bb38b
Compare
Update changelog. Fix translations. Fix docstrings. Update integreat_cms/cms/templates/pages/_page_xliff_export_overlay.html Co-authored-by: Timo Ludwig <ludwig@integreat-app.de> Update integreat_cms/cms/templates/pages/_page_xliff_export_overlay.html Co-authored-by: Timo Ludwig <ludwig@integreat-app.de> Update integreat_cms/cms/views/pages/page_bulk_actions.py Co-authored-by: Timo Ludwig <ludwig@integreat-app.de> Update integreat_cms/cms/templates/pages/page_tree.html Co-authored-by: Timo Ludwig <ludwig@integreat-app.de> Enhance interface for multilingual XLIFF export Improve readability Update integreat_cms/cms/templates/pages/_page_xliff_export_overlay.html Co-authored-by: Timo Ludwig <ludwig@integreat-app.de> Update integreat_cms/static/src/js/pages/xliff-export-overlay.ts Co-authored-by: Timo Ludwig <ludwig@integreat-app.de> Update integreat_cms/static/src/js/pages/xliff-export-overlay.ts Co-authored-by: Timo Ludwig <ludwig@integreat-app.de> Update integreat_cms/static/src/js/pages/xliff-export-overlay.ts Co-authored-by: Timo Ludwig <ludwig@integreat-app.de> Update integreat_cms/static/src/js/pages/xliff-export-overlay.ts Co-authored-by: Timo Ludwig <ludwig@integreat-app.de> Update integreat_cms/static/src/js/pages/xliff-export-overlay.ts Co-authored-by: Timo Ludwig <ludwig@integreat-app.de> Update integreat_cms/static/src/js/pages/xliff-export-overlay.ts Co-authored-by: Timo Ludwig <ludwig@integreat-app.de> Update translations
membralala
force-pushed
the
feature/bundle-xliff
branch
from
c0bb38b
to
1b950a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds a bulk action and a pop-up window for XLIFF export in multiple languages.
Proposed changes
Resolved issues
Fixes: #1549