Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translation of empty tags with SUMM.AI API for Easy German #1721

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

timobrembeck
Copy link
Member

Short description

Fix translation of empty tags with SUMM.AI API for Easy German

Proposed changes

  • Filter out all empty texts and don't translate them

Resolved issues

Fixes: #1720


Pull Request Review Guidelines

@timobrembeck timobrembeck requested a review from a team as a code owner September 28, 2022 15:59
@codeclimate
Copy link

codeclimate bot commented Sep 28, 2022

Code Climate has analyzed commit 21a89d7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 74.3%.

View more on Code Climate.

Copy link
Member

@ulliholtgrave ulliholtgrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't do an insight analysis of the behavior but for empty HTML tags this works fine 👍

@timobrembeck timobrembeck merged commit e4f46d9 into develop Sep 28, 2022
@timobrembeck timobrembeck deleted the bugfix/summ-ai-api branch September 28, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SUMM.AI translation not working for <p>&nbsp;</p> tags
2 participants