Fix autocompleting POI address for non-staff users #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 7079c0e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 74.2% (0.0% change). View more on Code Climate. |
seluianova
force-pushed
the
bugfix/autocompleting-poi-address-not-working-for-non-staff-users
branch
from
5da0bfa
to
1b8f874
Compare
david-venhoff
approved these changes
Oct 21, 2022
seluianova
force-pushed
the
bugfix/autocompleting-poi-address-not-working-for-non-staff-users
branch
from
1b8f874
to
e71f135
Compare
seluianova
force-pushed
the
bugfix/autocompleting-poi-address-not-working-for-non-staff-users
branch
from
37d3e6a
to
7079c0e
Compare
seluianova
deleted the
bugfix/autocompleting-poi-address-not-working-for-non-staff-users
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
At the moment, the auto completion feature introduced in #1744 does only work for staff users.
Proposed changes
Pass region_slug parameter into the view.
(Because our access control treats all views without the region_slug parameter as "staff area" and denies region users to access them.)
Side effects
Didn't find any
Resolved issues
Fixes: #1777
Pull Request Review Guidelines