Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TextLab HIX widget for non-staff users #1866

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Conversation

timobrembeck
Copy link
Member

Short description

Fix TextLab HIX widget for non-staff users

Proposed changes

  • Make the ajax view available in the region scope instead of network area which automatically denies access to non staff users

Resolved issues

Fixes: #1865


Pull Request Review Guidelines

@timobrembeck timobrembeck requested a review from a team as a code owner November 15, 2022 15:02
@timobrembeck timobrembeck mentioned this pull request Nov 15, 2022
@codeclimate
Copy link

codeclimate bot commented Nov 15, 2022

Code Climate has analyzed commit 5593df7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 74.5% (0.0% change).

View more on Code Climate.

Copy link
Member

@ulliholtgrave ulliholtgrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Member

@svenseeberg svenseeberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested & looks good! Thanks.

@timobrembeck timobrembeck merged commit cd25aae into develop Nov 15, 2022
@timobrembeck timobrembeck deleted the bugfix/textlab branch November 15, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Textlab widget not working for non-staff-members
3 participants