-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update linkcheck dependency #1977
Conversation
Code Climate has analyzed commit b1f97b8 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 0.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 74.6% (0.1% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very nice and seems to solve some issues 馃ぉ
As we are already updating our dependencies I would like to ask you to update our whole dependencies and bump TinyMCE to "^5.10.7". This would also fix the vulnerability of https://github.com/digitalfabrik/integreat-cms/security/dependabot/17.
8db292c
to
7351651
Compare
Alright, I now updated all dependencies, including the npm dependencies. This required a few changes in the lucide icon replacement, could you check again whether I messed something up? 馃槆 |
18d9335
to
8442697
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you a lot! This also worked on my machine. My only thought was that maybe we could add an entry to the changelog. I know that for changes that are mostly relevant to developers we don't add an entry, but since this PR fixes issues that are also relevant for members of the service-team it could be beneficial to add one. What do you think? :)
Declare module and import private function instead of using the copied and pasted code
Allow the preact renderer to identify which elements in the loop changed
- Run eslint with --fix flag - Run prettier after eslint to make sure the automatic fixes does not break the prettier format
8442697
to
b1f97b8
Compare
Ok, I added one entry for the broken hash anchors, or which changes did you mean? |
Short description
Finally, our upstream contributions to the linkcheck library have been released! 馃帀
Proposed changes
Side effects
A lot of other improvements to the link checker, the most important being:
findlinks
command now deletes outdated links - no need to delete the entire link database anymoreResolved issues
Fixes: #1695
Fixes: #1818
Pull Request Review Guidelines