Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linkcheck dependency #1977

Merged
merged 6 commits into from
Jan 10, 2023
Merged

Update linkcheck dependency #1977

merged 6 commits into from
Jan 10, 2023

Conversation

timobrembeck
Copy link
Member

Short description

Finally, our upstream contributions to the linkcheck library have been released! 馃帀

Proposed changes

  • Update dependencies (including linkcheck version 2.0.0)
  • Remove workaround for linkcheck app
  • Fix the link test data

Side effects

A lot of other improvements to the link checker, the most important being:

  • No crash of the process anymore when long URLs occur
  • The findlinks command now deletes outdated links - no need to delete the entire link database anymore
  • Broken anchors are now considered valid links instead of broken links (this means we do not need a separate warning category, see Add warning category to broken link checker聽#1695)
  • SSL certificates are now verified

Resolved issues

Fixes: #1695
Fixes: #1818


Pull Request Review Guidelines

@timobrembeck timobrembeck requested a review from a team as a code owner December 18, 2022 02:28
@codeclimate
Copy link

codeclimate bot commented Dec 18, 2022

Code Climate has analyzed commit b1f97b8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 74.6% (0.1% change).

View more on Code Climate.

Copy link
Member

@ulliholtgrave ulliholtgrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very nice and seems to solve some issues 馃ぉ

As we are already updating our dependencies I would like to ask you to update our whole dependencies and bump TinyMCE to "^5.10.7". This would also fix the vulnerability of https://github.com/digitalfabrik/integreat-cms/security/dependabot/17.

@timobrembeck
Copy link
Member Author

As we are already updating our dependencies I would like to ask you to update our whole dependencies and bump TinyMCE to "^5.10.7". This would also fix the vulnerability of https://github.com/digitalfabrik/integreat-cms/security/dependabot/17.

Alright, I now updated all dependencies, including the npm dependencies. This required a few changes in the lucide icon replacement, could you check again whether I messed something up? 馃槆

@timobrembeck timobrembeck force-pushed the enhancement/linkcheck-app branch 2 times, most recently from 18d9335 to 8442697 Compare January 5, 2023 14:37
Copy link
Contributor

@JoeyStk JoeyStk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot! This also worked on my machine. My only thought was that maybe we could add an entry to the changelog. I know that for changes that are mostly relevant to developers we don't add an entry, but since this PR fixes issues that are also relevant for members of the service-team it could be beneficial to add one. What do you think? :)

Declare module and import private function instead of using the copied and pasted code
Allow the preact renderer to identify which elements in the loop changed
- Run eslint with --fix flag
- Run prettier after eslint to make sure the automatic fixes does not break the prettier format
@timobrembeck
Copy link
Member Author

My only thought was that maybe we could add an entry to the changelog. I know that for changes that are mostly relevant to developers we don't add an entry, but since this PR fixes issues that are also relevant for members of the service-team it could be beneficial to add one. What do you think? :)

Ok, I added one entry for the broken hash anchors, or which changes did you mean?
The other changes are probably more infrastructure-bound, since the issues will not be fixed as soon as the new version is released and installed, but only when we perform the next re-scan of the links...

@timobrembeck timobrembeck merged commit 0e3884c into develop Jan 10, 2023
@timobrembeck timobrembeck deleted the enhancement/linkcheck-app branch January 10, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken Link Checker stops when facing URL longer than 255 chars Add warning category to broken link checker
3 participants